Commit graph

1 commit

Author SHA1 Message Date
Benjamin Slingo ef7e077ae2 Refactor EventService: eliminate duplication, apply DRY/KISS principles
BREAKING: Removed CreateEventRequest - unused for direct creation
ADDED: UpdateEventRequest - clean editing with image support
IMPROVED: EventService now contains business logic, not wrapper calls

Architecture Changes:
- Before: Handler → Service → db::events → SQL (wasteful)
- After:  Handler → Service → Direct SQL + Business Logic (clean)

Key Improvements:
 All EventService methods use direct SQL with real business logic
 Eliminated pointless db::events wrapper functions
 Added missing V2 service methods for consistency
 Fixed handler pattern violations (no more direct db calls)
 Preserved email notifications and HTTP response formats
 Applied sanitization, validation, error handling in services

Changes:
- Remove CreateEventRequest/V2 (unused create paths)
- Add UpdateEventRequest with image field (no redundant thumbnail)
- Migrate all EventService methods to direct SQL + business logic
- Fix v2/events.rs to use proper service methods consistently
- Remove create/update routes and handlers (unused)
- Maintain backward compatibility for all APIs

Next: Apply same DRY/KISS cleanup to BulletinService and others
2025-08-28 22:42:45 -04:00